linux-kernel - Re: [PATCH] usb: xhci: Fix compiler warning in xhci.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024070912-tigress-glacier-273d@gregkh>
Date: Tue, 9 Jul 2024 07:11:49 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Shivani Gupta <shivani07g@...il.com>
Cc: laurent.pinchart@...asonboard.com, mchehab@...nel.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	mathias.nyman@...el.com, linux-usb@...r.kernel.org,
	skhan@...uxfoundation.org, javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] usb: xhci: Fix compiler warning in xhci.c

On Tue, Jul 09, 2024 at 03:06:04AM +0000, Shivani Gupta wrote:
> Fixes the following compiler warnings by changing the comment syntax
> from "/**" to "/*" in the specified comments:

That's not a normal compiler warning, but rather a documentation builder
warning, right?

> 
> drivers/usb/host/xhci.c:1369: warning: Function parameter or struct member
> 'desc' not described in 'xhci_get_endpoint_index'
> 
> Signed-off-by: Shivani Gupta <shivani07g@...il.com>
> ---
>  drivers/usb/host/xhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 37eb37b0affa..67168661aa52 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1355,7 +1355,7 @@ static void xhci_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
>  		usb_hcd_unmap_urb_for_dma(hcd, urb);
>  }
>  
> -/**
> +/*

This feels wrong, why not fix up the kerneldoc instead?

thanks,

greg k-h