linux-kernel - Re: [PATCH 1/3] PCI: qcom: Fix missing error code in qcom_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240709051155.GG3820@thinkpad>
Date: Tue, 9 Jul 2024 10:41:55 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Krishna chaitanya chundru <quic_krichai@...cinc.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] PCI: qcom: Fix missing error code in
 qcom_pcie_probe()

On Mon, Jul 08, 2024 at 01:05:36PM -0500, Dan Carpenter wrote:
> Return a negative error code if dev_pm_opp_find_freq_floor() fails.
> Don't return success.
> 
> Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

- Mani

> ---
>  drivers/pci/controller/dwc/pcie-qcom.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 26405fcfa499..1d36311f9adb 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1574,7 +1574,8 @@ static int qcom_pcie_probe(struct platform_device *pdev)
>  	if (!ret) {
>  		opp = dev_pm_opp_find_freq_floor(dev, &max_freq);
>  		if (IS_ERR(opp)) {
> -			dev_err_probe(pci->dev, PTR_ERR(opp),
> +			ret = PTR_ERR(opp);
> +			dev_err_probe(pci->dev, ret,
>  				      "Unable to find max freq OPP\n");
>  			goto err_pm_runtime_put;
>  		} else {
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்