linux-kernel - Re: [PATCH v2] selftests/rtc:Fix a resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e4d88f3-a45b-4d30-bec6-75636c854d43@linuxfoundation.org>
Date: Wed, 10 Jul 2024 10:00:16 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-rtc@...r.kernel.org, shuah@...nel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests/rtc:Fix a resource leak

On 7/10/24 01:55, Alexandre Belloni wrote:
> On 10/07/2024 00:43:09-0700, Zhu Jun wrote:
>> The opened file should be closed before exit, otherwise resource leak
>> will occur that this problem was discovered by code reading
> 
> The question is still why should it be closed before exit as it will be
> closed on exit?
> 

Zhu Jun,

+1 on this. I have responded to your other patches that do the same
in other tests. There is no need to make such changes.

thanks,
-- Shuah