linux-kernel - Re: [PATCH v2] selftests/rtc:Fix a resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240710075513332c564f@mail.local>
Date: Wed, 10 Jul 2024 09:55:13 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-rtc@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v2] selftests/rtc:Fix a resource leak

On 10/07/2024 00:43:09-0700, Zhu Jun wrote:
> The opened file should be closed before exit, otherwise resource leak
> will occur that this problem was discovered by code reading

The question is still why should it be closed before exit as it will be
closed on exit?

> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
> From a good programming practice perspective, especially in more complex programs, 
> explicitly freeing allocated memory is a good habit!
> 
> 
>  tools/testing/selftests/rtc/setdate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/rtc/setdate.c b/tools/testing/selftests/rtc/setdate.c
> index b303890b3de2..17a00affb0ec 100644
> --- a/tools/testing/selftests/rtc/setdate.c
> +++ b/tools/testing/selftests/rtc/setdate.c
> @@ -65,6 +65,7 @@ int main(int argc, char **argv)
>  	retval = ioctl(fd, RTC_RD_TIME, &current);
>  	if (retval == -1) {
>  		perror("RTC_RD_TIME ioctl");
> +		close(fd);
>  		exit(errno);
>  	}
>  
> -- 
> 2.17.1
> 
> 
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com