linux-kernel - Re: [PATCH v3] net: fix rc7's __skb_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <934ac0b8491ec56dd35b9f0ab7422daa1926c4df.camel@redhat.com>
Date: Wed, 10 Jul 2024 18:19:25 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Hugh Dickins <hughd@...gle.com>
Cc: Sagi Grimberg <sagi@...mberg.me>, Jakub Kicinski <kuba@...nel.org>, Eric
 Dumazet <edumazet@...gle.com>, Thorsten Leemhuis
 <regressions@...mhuis.info>,  regressions@...ts.linux.dev,
 netdev@...r.kernel.org,  linux-kernel@...r.kernel.org, Linus Torvalds
 <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v3] net: fix rc7's __skb_datagram_iter()

On Wed, 2024-07-10 at 08:36 -0700, Hugh Dickins wrote:
> X would not start in my old 32-bit partition (and the "n"-handling looks
> just as wrong on 64-bit, but for whatever reason did not show up there):
> "n" must be accumulated over all pages before it's added to "offset" and
> compared with "copy", immediately after the skb_frag_foreach_page() loop.
> 
> Fixes: d2d30a376d9c ("net: allow skb_datagram_iter to be called from any context")
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> Reviewed-by: Sagi Grimberg <sagi@...mberg.me>
> ---
> v3: added reviewed-by Sagi, try sending direct to Linus

V2 is already applied to the 'net' tree and will be included in our
next 'net' PR, coming tomorrow.

It looks like the netdev bot decided it needed an holiday (or was
fooled by the threaded submission for v2), so no notification landed on
the ML.

@Hugh: next time please check the current tree status or patchwork
before submitting a new revision. And please avoid submitting the new
version in reply to a previous one, it makes things difficult for our
CI.

Thanks,

Paolo