linux-kernel - Re: [PATCH] selftests: openat2: don't print total number of tests and then skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d82fa16-ed2e-41f1-a466-c752032b6f68@linuxfoundation.org>
Date: Wed, 10 Jul 2024 10:18:31 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>
Cc: Al Viro <viro@...iv.linux.org.uk>, kernel@...labora.com,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Aleksa Sarai <cyphar@...har.com>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: openat2: don't print total number of tests and
 then skip

On 7/10/24 03:33, Muhammad Usama Anjum wrote:
> Hi Shuah,
> 
> Can you take the patch as is or by removing following from this patch:
> 
> -	if (geteuid() != 0)
> +	if (geteuid())

As Aleksa mentioned, geteuid() != 0 is preferred.

> 
> On 7/2/24 12:02 PM, Muhammad Usama Anjum wrote:
>> On 7/1/24 2:14 PM, Aleksa Sarai wrote:
>>> On 2024-07-01, Muhammad Usama Anjum <usama.anjum@...labora.com> wrote:
>>>> Adding more people for review
>>>>
>>>> On 5/23/24 2:46 AM, Muhammad Usama Anjum wrote:
>>>>> Don't print that 88 sub-tests are going to be executed. But then skip.
>>>>> The error is printed that executed test was only 1 while 88 should have
>>>>> run:
>>>>>
>>>>> Old output:
>>>>>    TAP version 13
>>>>>    1..88
>>>>>    ok 2 # SKIP all tests require euid == 0
>>>>>    # Planned tests != run tests (88 != 1)
>>>>>    # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>>>>>
>>>>> New and correct output:
>>>>>    TAP version 13
>>>>>    1..0 # SKIP all tests require euid == 0

I think having total number tell you how many tests are there.
I don't this this is good change.

thanks,
-- Shuah