linux-kernel - Re: [PATCH] selftests: openat2: don't print total number of tests and then skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0007f80-d44b-42fa-afd4-fdaeb3b89f70@collabora.com>
Date: Wed, 10 Jul 2024 14:33:08 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Shuah Khan <shuah@...nel.org>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Al Viro <viro@...iv.linux.org.uk>, kernel@...labora.com,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Aleksa Sarai <cyphar@...har.com>
Subject: Re: [PATCH] selftests: openat2: don't print total number of tests and
 then skip

Hi Shuah,

Can you take the patch as is or by removing following from this patch:

-	if (geteuid() != 0)
+	if (geteuid())

Thanks,
Usama

On 7/2/24 12:02 PM, Muhammad Usama Anjum wrote:
> On 7/1/24 2:14 PM, Aleksa Sarai wrote:
>> On 2024-07-01, Muhammad Usama Anjum <usama.anjum@...labora.com> wrote:
>>> Adding more people for review
>>>
>>> On 5/23/24 2:46 AM, Muhammad Usama Anjum wrote:
>>>> Don't print that 88 sub-tests are going to be executed. But then skip.
>>>> The error is printed that executed test was only 1 while 88 should have
>>>> run:
>>>>
>>>> Old output:
>>>>   TAP version 13
>>>>   1..88
>>>>   ok 2 # SKIP all tests require euid == 0
>>>>   # Planned tests != run tests (88 != 1)
>>>>   # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>>>>
>>>> New and correct output:
>>>>   TAP version 13
>>>>   1..0 # SKIP all tests require euid == 0
>>>>
>>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>>>> ---
>>>>  tools/testing/selftests/openat2/resolve_test.c | 5 +++--
>>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tools/testing/selftests/openat2/resolve_test.c b/tools/testing/selftests/openat2/resolve_test.c
>>>> index bbafad440893c..5472ec478d227 100644
>>>> --- a/tools/testing/selftests/openat2/resolve_test.c
>>>> +++ b/tools/testing/selftests/openat2/resolve_test.c
>>>> @@ -508,12 +508,13 @@ void test_openat2_opath_tests(void)
>>>>  int main(int argc, char **argv)
>>>>  {
>>>>  	ksft_print_header();
>>>> -	ksft_set_plan(NUM_TESTS);
>>>>  
>>>>  	/* NOTE: We should be checking for CAP_SYS_ADMIN here... */
>>>> -	if (geteuid() != 0)
>>>> +	if (geteuid())
>>
>> This change isn't necessary, != 0 makes what we're checking clearer.
> It is wasteful to write != 0 when you can achieve the same without it.
> 
> I can update the patch by removing it. Please can you provide a reviewed-by
> tag for remaining patch?
> 
>>
>>>>  		ksft_exit_skip("all tests require euid == 0\n");
>>>>  
>>>> +	ksft_set_plan(NUM_TESTS);
>>>> +
>>>>  	test_openat2_opath_tests();
>>>>  
>>>>  	if (ksft_get_fail_cnt() + ksft_get_error_cnt() > 0)
>>>
>>> -- 
>>> BR,
>>> Muhammad Usama Anjum
>>
> 

-- 
BR,
Muhammad Usama Anjum