linux-kernel - Re: [PATCH fs/bfs 1/2] bfs: fix null-ptr-deref in bfs_move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd942b65-b6d7-0e0f-be4d-c3b950ee008f@basealt.ru>
Date: Thu, 11 Jul 2024 00:57:17 +0300
From: Василий Ковалев
 <kovalevvv@...ealt.ru>
To: Markus Elfring <Markus.Elfring@....de>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 "Tigran A. Aivazian" <aivazian.tigran@...il.com>, dutyrok@...linux.org,
 linux-fsdevel@...r.kernel.org, lvc-patches@...uxtesting.org
Subject: Re: [PATCH fs/bfs 1/2] bfs: fix null-ptr-deref in bfs_move_block

10.07.2024 23:09, Markus Elfring wrote:
>> Add a check to ensure 'sb_getblk' did not return NULL before copying data.
> 
> Wording suggestion:
>                          that a sb_getblk() call
> 
> 
> How do you think about to use a summary phrase like
> “Prevent null pointer dereference in bfs_move_block()”?

Ok, I'll change it in the next version:

bfs: prevent null pointer dereference in bfs_move_block()

Add a check to ensure that a sb_getblk() call did not return NULL before 
copying data.

> 
> …
>> +++ b/fs/bfs/file.c
>> @@ -35,16 +35,22 @@ static int bfs_move_block(unsigned long from, unsigned long to,
>>   					struct super_block *sb)
>>   {
>>   	struct buffer_head *bh, *new;
>> +	int err;
> 
> Can a statement (like the following) become more appropriate for such
> a function implementation?
> 
> 	int ret = 0;

Yes, thank you.

> 
> Regards,
> Markus
-- 
Regards,
Vasiliy Kovalev