lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240710163407.6393021f@canb.auug.org.au>
Date: Wed, 10 Jul 2024 16:34:07 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Lee Jones <lee@...nel.org>
Cc: Christian Marangi <ansuelsmth@...il.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>
Subject: linux-next: build failure after merge of the leds-lj tree

Hi all,

After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/leds/leds-lp5521.c: In function 'lp5521_selftest':
drivers/leds/leds-lp5521.c:189:33: error: macro "guard" passed 2 arguments, but takes just 1
  189 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp5521.c:12:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5521.c:189:9: error: 'guard' undeclared (first use in this function)
  189 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5521.c:189:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp5523.c: In function 'lp5523_selftest':
drivers/leds/leds-lp5523.c:192:33: error: macro "guard" passed 2 arguments, but takes just 1
  192 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp5523.c:12:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5523.c:192:9: error: 'guard' undeclared (first use in this function)
  192 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5523.c:192:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp5562.c: In function 'lp5562_led_brightness':
drivers/leds/leds-lp5562.c:175:33: error: macro "guard" passed 2 arguments, but takes just 1
  175 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp5562.c:10:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5562.c:175:9: error: 'guard' undeclared (first use in this function)
  175 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5562.c:175:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp5562.c: In function 'lp5562_store_pattern':
drivers/leds/leds-lp5562.c:272:33: error: macro "guard" passed 2 arguments, but takes just 1
  272 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5562.c:272:9: error: 'guard' undeclared (first use in this function)
  272 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp5562.c: In function 'lp5562_store_engine_mux':
drivers/leds/leds-lp5562.c:324:33: error: macro "guard" passed 2 arguments, but takes just 1
  324 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp5562.c:324:9: error: 'guard' undeclared (first use in this function)
  324 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_led_brightness':
drivers/leds/leds-lp55xx-common.c:276:33: error: macro "guard" passed 2 arguments, but takes just 1
  276 |         guard(mutex, &chip->lock);
      |                                 ^
In file included from drivers/leds/leds-lp55xx-common.c:13:
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:276:9: error: 'guard' undeclared (first use in this function)
  276 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c:276:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_multicolor_brightness':
drivers/leds/leds-lp55xx-common.c:291:33: error: macro "guard" passed 2 arguments, but takes just 1
  291 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:291:9: error: 'guard' undeclared (first use in this function)
  291 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'led_current_store':
drivers/leds/leds-lp55xx-common.c:409:33: error: macro "guard" passed 2 arguments, but takes just 1
  409 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:409:9: error: 'guard' undeclared (first use in this function)
  409 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'run_engine_store':
drivers/leds/leds-lp55xx-common.c:637:33: error: macro "guard" passed 2 arguments, but takes just 1
  637 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:637:9: error: 'guard' undeclared (first use in this function)
  637 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_engine_mode':
drivers/leds/leds-lp55xx-common.c:676:33: error: macro "guard" passed 2 arguments, but takes just 1
  676 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:676:9: error: 'guard' undeclared (first use in this function)
  676 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_engine_load':
drivers/leds/leds-lp55xx-common.c:704:33: error: macro "guard" passed 2 arguments, but takes just 1
  704 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:704:9: error: 'guard' undeclared (first use in this function)
  704 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_engine_leds':
drivers/leds/leds-lp55xx-common.c:803:33: error: macro "guard" passed 2 arguments, but takes just 1
  803 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:803:9: error: 'guard' undeclared (first use in this function)
  803 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c:798:17: error: unused variable 'ret' [-Werror=unused-variable]
  798 |         ssize_t ret;
      |                 ^~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_show_master_fader':
drivers/leds/leds-lp55xx-common.c:827:33: error: macro "guard" passed 2 arguments, but takes just 1
  827 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:827:9: error: 'guard' undeclared (first use in this function)
  827 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_master_fader':
drivers/leds/leds-lp55xx-common.c:851:33: error: macro "guard" passed 2 arguments, but takes just 1
  851 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:851:9: error: 'guard' undeclared (first use in this function)
  851 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_show_master_fader_leds':
drivers/leds/leds-lp55xx-common.c:870:33: error: macro "guard" passed 2 arguments, but takes just 1
  870 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:870:9: error: 'guard' undeclared (first use in this function)
  870 |         guard(mutex, &chip->lock);
      |         ^~~~~
drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_store_master_fader_leds':
drivers/leds/leds-lp55xx-common.c:901:33: error: macro "guard" passed 2 arguments, but takes just 1
  901 |         guard(mutex, &chip->lock);
      |                                 ^
include/linux/cleanup.h:166: note: macro "guard" defined here
  166 | #define guard(_name) \
      | 
drivers/leds/leds-lp55xx-common.c:901:9: error: 'guard' undeclared (first use in this function)
  901 |         guard(mutex, &chip->lock);
      |         ^~~~~
cc1: all warnings being treated as errors

Caused by commit

  efd0d1cbb8c5 ("leds: leds-lp55xx: Convert mutex lock/unlock to guard API")

I have used the led-lj tree from next-20240709 for today.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ