linux-kernel - Re: [PATCH v2 1/2] dt-bindings: PCI: Document compatible for QCS9100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e429e0d5-ed88-44c7-aa76-62abd593a3d1@quicinc.com>
Date: Wed, 10 Jul 2024 14:37:18 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi
	<lpieralisi@...nel.org>,
        Krzysztof Wilczyński
	<kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: Document compatible for QCS9100



On 7/10/2024 12:29 AM, Bjorn Helgaas wrote:
> On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote:
>> Document compatible for QCS9100 platform.
> 
> Add blank line for paragraph breaks.

A blank line will be added in the next verion patch series.

> 
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI
>> based PCIe.
> 
> Not connected to the patch below.  Move to where it is relevant.

As mentioned in the cover letter, we will also push the QCS9100 device 
tree patch series to upstream after all the binding and driver patches 
are reviewd. The QCS9100 device tree is directly renamed from the 
SA8775p device tree.

This comment message serves to explain why we need to push this PCIe 
binding patch, thus avoiding any questions from reviews about why we are 
not continuing to use the "qcom,pcie-sa8775p" compatible name.

If you still think that this comment message is not necessay here, I 
will move this comment message from binding and driver patches to the 
cover letter.

> 
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>> ---
>>   Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>> index efde49d1bef8..4de33df6963f 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>> @@ -16,7 +16,10 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,pcie-sa8775p
>> +    items:
>> +      - enum:
>> +          - qcom,pcie-qcs9100
>> +          - qcom,pcie-sa8775p
>>   
>>     reg:
>>       minItems: 6
>>
>> -- 
>> 2.25.1
>>

-- 
Thx and BRs,
Tengfei Fan