linux-kernel - Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b67cbcd-d16a-18e3-be8c-6003d381e99f@linux.intel.com>
Date: Thu, 11 Jul 2024 18:39:04 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Nikita Travkin <nikita@...n.ru>
cc: Geert Uytterhoeven <geert+renesas@...der.be>, 
    Hans de Goede <hdegoede@...hat.com>, 
    Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on
 ARCH_QCOM

On Thu, 11 Jul 2024, Nikita Travkin wrote:

> Geert Uytterhoeven писал(а) 11.07.2024 19:30:
> > The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> > Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
> > ARCH_QCOM, to prevent asking the user about this driver when configuring
> > a kernel without Qualcomm SoC support.
> > 
> 
> Oh yeah, you're right. Thanks for fixing this!
> 
> Acked-by: Nikita Travkin <nikita@...n.ru>
> 
> We should probably do the same for the C630 driver as well...

Yes, Geert sent another patch for that already.

-- 
 i.

> > Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> >  drivers/platform/arm64/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> > index 8c103b3150d1d0a6..058a4baa216a83b8 100644
> > --- a/drivers/platform/arm64/Kconfig
> > +++ b/drivers/platform/arm64/Kconfig
> > @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
> >  
> >  config EC_ACER_ASPIRE1
> >  	tristate "Acer Aspire 1 Embedded Controller driver"
> > +	depends on ARCH_QCOM || COMPILE_TEST
> >  	depends on I2C
> >  	depends on DRM
> >  	depends on POWER_SUPPLY
>