[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <315e6f5fa10cc779ca399f6aec203c32@trvn.ru>
Date: Thu, 11 Jul 2024 20:30:17 +0500
From: Nikita Travkin <nikita@...n.ru>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Hans de Goede <hdegoede@...hat.com>, Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com>, Bryan O'Donoghue
<bryan.odonoghue@...aro.org>, platform-driver-x86@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on
ARCH_QCOM
Geert Uytterhoeven писал(а) 11.07.2024 19:30:
> The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Acer Aspire 1 laptop. Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
>
Oh yeah, you're right. Thanks for fixing this!
Acked-by: Nikita Travkin <nikita@...n.ru>
We should probably do the same for the C630 driver as well...
> Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> drivers/platform/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 8c103b3150d1d0a6..058a4baa216a83b8 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
>
> config EC_ACER_ASPIRE1
> tristate "Acer Aspire 1 Embedded Controller driver"
> + depends on ARCH_QCOM || COMPILE_TEST
> depends on I2C
> depends on DRM
> depends on POWER_SUPPLY
Powered by blists - more mailing lists