linux-kernel - Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZpBFjzIEpq6RIM8I@casper.infradead.org>
Date: Thu, 11 Jul 2024 21:50:23 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Yang Shi <shy828301@...il.com>
Cc: Yves-Alexis Perez <corsac@...ian.org>, jirislaby@...nel.org,
	surenb@...gle.com, riel@...riel.com, cl@...ux.com,
	akpm@...ux-foundation.org, yang@...amperecomputing.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Salvatore Bonaccorso <carnil@...ian.org>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32
 bit

On Thu, Jul 11, 2024 at 01:47:00PM -0700, Yang Shi wrote:
> +++ b/mm/huge_memory.c
> @@ -857,7 +857,8 @@ static unsigned long
> __thp_get_unmapped_area(struct file *filp,
>         loff_t off_align = round_up(off, size);
>         unsigned long len_pad, ret, off_sub;
> 
> -       if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall())
> +       if (IS_ENABLED(CONFIG_32BIT) || IS_ENABLED(CONFIG_X86_32) ||
> +           in_compat_syscall())

Why not:

	if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall())