[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1a6b8053-d053-4e84-a69a-c21d07f325bf@quicinc.com>
Date: Thu, 11 Jul 2024 20:14:40 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Krzysztof Kozlowski
<krzk@...nel.org>, <rfoss@...nel.org>,
<todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>
CC: <quic_eberman@...cinc.com>, <linux-media@...r.kernel.org>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
Yongsheng Li
<quic_yon@...cinc.com>
Subject: Re: [PATCH 09/13] media: qcom: camss: Add CSID Gen3 support for
SM8550
Hi Bryan,
On 7/11/2024 8:00 PM, Bryan O'Donoghue wrote:
> On 11/07/2024 12:41, Depeng Shao wrote:
>>>> Yes, these are some sequences to initialize the HW.
>>>
>>> Hm? It's like you ignore the problem and just answer with whatever to
>>> shut up the reviewer. Instead of replying with the same, address the
>>> problem. Why ordering is not a problem here?
>>>
>>
>> Sorry, I didn't mean that, was trying to understand the problem, then
>> just sent out the mail by mistake.
>> Do you mean we should use writel to ensure the strict sequences?
>> Thanks for catching this problem, this problem is also in the the
>> existing camss driver. I will check all of them in this series, but
>> the problem in some existing camss drivers, maybe Bryan from Linaro
>> can help to fix them, since I don't have these devices to verify the
>> modifications.
>
> _relaxed is used I'm sure because that's what's always been used and
> what downstream does.
>
> Is there a good reason for it ? None that I can think of.
>
> Krzysztof is right, there's no good reason to use relaxed() here at all,
> you should drop it.
>
> ---
> bod
Sure, I will drop the _relaxed.
Most io_write don't use _relaxed in the Qualcomm downstream camera
driver, but few strict timing required code really have this problem, I
will fix them.
Thanks for highlight it.
Thanks,
Depeng
Powered by blists - more mailing lists