linux-kernel - Re: [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wva6x7hrksgvoffpzi5h7q6ucfhdj2fngnezdmnru6gktgmf6q@yfs3lvzrdrhf>
Date: Thu, 11 Jul 2024 18:11:13 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Michal Simek <michal.simek@....com>, 
	Alexander Stein <alexander.stein@...tq-group.com>, Tony Luck <tony.luck@...el.com>, 
	James Morse <james.morse@....com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Robert Richter <rric@...nel.org>, Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@...inx.com>, 
	Dinh Nguyen <dinguyen@...nel.org>, Shubhrajyoti Datta <shubhrajyoti.datta@...il.com>, 
	Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-arm-kernel@...ts.infradead.org, linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field
 setting

On Tue, Jul 09, 2024 at 01:35:22PM +0200, Borislav Petkov wrote:
> On Thu, Jun 27, 2024 at 08:32:09PM +0300, Serge Semin wrote:
> > The mem_ctl_info.scrub_cap field is supposed to be set with the ECC
> > scrub-related flags. Instead the driver erroneously initializes it with
> > the SCRUB_HW_SRC flag ID. It's definitely wrong, but it hasn't caused any
> > problem so far since the structure field isn't used by the EDAC core. Fix
> > it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field.
> 
> This hasn't been used at least since it got added by
> 
> commit da9bb1d27b21cb24cbb6a2efb5d3c464d357a01e
> Author: Alan Cox <alan@...rguk.ukuu.org.uk>
> Date:   Wed Jan 18 17:44:13 2006 -0800
> 
>     [PATCH] EDAC: core EDAC support code
> 
> AFAICT.
> 
> Please remove ->scrub_cap along with enum scrub_type instead.
> 
> We can always resurrect it if needed.

Agreed. I'll drop all of these from the EDAC core and drivers.

-Serge(y)

> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette