linux-kernel - Re: [PATCH] driver:core: no need to set a default value for want

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024071101-cytoplast-overflow-d8cd@gregkh>
Date: Thu, 11 Jul 2024 17:13:21 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: 李哲 <sensor1010@....com>
Cc: rafael@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver:core: no need to set a default value for
 want_async

On Thu, Jul 11, 2024 at 08:05:45AM -0700, 李哲 wrote:
> The default value of this member variable is false,
> which is only set to true when asynchronous loading is required,
> and does not need to be set to false during synchronization
> 
> Signed-off-by: 李哲 <sensor1010@....com>
> ---
>  drivers/base/dd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index d047919d1f5e..47351d98f6e1 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1014,7 +1014,6 @@ static int __device_attach(struct device *dev, bool allow_async)
>  		struct device_attach_data data = {
>  			.dev = dev,
>  			.check_async = allow_async,
> -			.want_async = false,

This is good to keep as-is for documentation alone, it doesn't actually
change anything and makes it obvious.

thanks,

greg k-h