linux-kernel - Re: [PATCH] xfs: remove unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <512241eb-2190-40f4-aeae-066d67464362@nvidia.com>
Date: Fri, 12 Jul 2024 17:34:14 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Chandan Babu R
	<chandan.babu@...cle.com>
CC: "Darrick J. Wong" <djwong@...nel.org>, "linux-xfs@...r.kernel.org"
	<linux-xfs@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] xfs: remove unnecessary check

On 7/12/2024 7:07 AM, Dan Carpenter wrote:
> We checked that "pip" is non-NULL at the start of the if else statement
> so there is no need to check again here.  Delete the check.
> 
> Signed-off-by: Dan Carpenter<dan.carpenter@...aro.org>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck