linux-kernel - Re: [PATCH] xfs: remove unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240712151848.GS612460@frogsfrogsfrogs>
Date: Fri, 12 Jul 2024 08:18:48 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Chandan Babu R <chandan.babu@...cle.com>, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] xfs: remove unnecessary check

On Fri, Jul 12, 2024 at 09:07:36AM -0500, Dan Carpenter wrote:
> We checked that "pip" is non-NULL at the start of the if else statement
> so there is no need to check again here.  Delete the check.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Yep.
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_inode_util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_inode_util.c b/fs/xfs/libxfs/xfs_inode_util.c
> index 032333289113..cc38e1c3c3e1 100644
> --- a/fs/xfs/libxfs/xfs_inode_util.c
> +++ b/fs/xfs/libxfs/xfs_inode_util.c
> @@ -308,7 +308,7 @@ xfs_inode_init(
>  		    !vfsgid_in_group_p(i_gid_into_vfsgid(args->idmap, inode)))
>  			inode->i_mode &= ~S_ISGID;
>  
> -		ip->i_projid = pip ? xfs_get_initial_prid(pip) : 0;
> +		ip->i_projid = xfs_get_initial_prid(pip);
>  	}
>  
>  	ip->i_disk_size = 0;
> -- 
> 2.43.0
> 
>