linux-kernel - Re: [PATCH v3 1/1] scsi: ufs: core: Support Updating UIC Command Timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4062986c-61be-473d-b8bc-b40d9260f301@acm.org>
Date: Fri, 12 Jul 2024 10:51:55 -0700
From: Bart Van Assche <bvanassche@....org>
To: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>, quic_cang@...cinc.com,
 quic_nitirawa@...cinc.com, avri.altman@....com, peter.wang@...iatek.com,
 manivannan.sadhasivam@...aro.org, minwoo.im@...sung.com,
 adrian.hunter@...el.com, martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
 "James E.J. Bottomley" <jejb@...ux.ibm.com>, Bean Huo <beanhuo@...ron.com>,
 Maramaina Naresh <quic_mnaresh@...cinc.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/1] scsi: ufs: core: Support Updating UIC Command
 Timeout

On 7/11/24 6:20 PM, Bao D. Nguyen wrote:
> Maybe I misunderstood your comment. You probably was concerned about the 
> execution time of param_set_int(val, kp) vs a single assignment 
> instruction 'uic_cmd_timeout = n;', right? If that's the case, I'll 
> update the patch.

I'm concerned about the two conversions yielding different results, e.g.
because of different handling of base prefixes (e.g. 0x) or different
handling of overflows. This patch would be easier to review if the
conversion from string to int only happens once.

Thanks,

Bart.