linux-kernel - Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31e73e81-e60f-4d0b-b0ac-118f1dc72610@sirena.org.uk>
Date: Fri, 12 Jul 2024 19:19:33 +0100
From: Mark Brown <broonie@...nel.org>
To: Jaroslav Kysela <perex@...ex.cz>
Cc: Takashi Iwai <tiwai@...e.de>, Takashi Iwai <tiwai@...e.com>,
	Shuah Khan <shuah@...nel.org>, linux-sound@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test
 names

On Fri, Jul 12, 2024 at 06:25:21PM +0200, Jaroslav Kysela wrote:
> On 12. 07. 24 15:00, Mark Brown wrote:

> > The trouble with the ID field is that it's too short and seems likely to
> > create collisions, for example HDA stuff just seems to default to NVidia
> > for nVidia cards which seems very likely to create collisions if someone
> > has two graphics cards in their system.

> The default IDs are always unique - see snd_card_set_id_no_lock() in
> sound/core/init.c . Basically, the suffix will follow the device probe order
> in this case.

Sure, but the genesis of this patch is that probe order isn't
sufficiently stable and we want to avoid names based on it...  using the
ID will be more likely to work out stable than just pure probe order but
it's still got the same issue.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)