linux-kernel - Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1be6bec-90f5-4bb3-b6b0-8524095fc490@perex.cz>
Date: Fri, 12 Jul 2024 18:25:21 +0200
From: Jaroslav Kysela <perex@...ex.cz>
To: Mark Brown <broonie@...nel.org>
Cc: Takashi Iwai <tiwai@...e.de>, Takashi Iwai <tiwai@...e.com>,
 Shuah Khan <shuah@...nel.org>, linux-sound@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test
 names

On 12. 07. 24 15:00, Mark Brown wrote:
> On Fri, Jul 12, 2024 at 11:20:05AM +0200, Jaroslav Kysela wrote:
>> On 12. 07. 24 10:21, Takashi Iwai wrote:
> 
>>> OTOH, longname can be really ugly to read, and it can vary because it
>>> often embeds address or irq numbers in the string.
> 
> Capturing that variation is one of the goals - it should mostly be
> stable between runs.
> 
>>> If a general name is the goal, how about using shortname instead?
> 
>>> Or use id field, as Jaroslav suggested, but without the card number
>>> suffix; then it's unique among multiple cards.
> 
>> I prefer this (use only ID field). This string can be also set in the user
>> space using sysfs/udev, so the administrator may change it if the default is
>> not ideal.
> 
> The trouble with the ID field is that it's too short and seems likely to
> create collisions, for example HDA stuff just seems to default to NVidia
> for nVidia cards which seems very likely to create collisions if someone
> has two graphics cards in their system.

The default IDs are always unique - see snd_card_set_id_no_lock() in 
sound/core/init.c . Basically, the suffix will follow the device probe order 
in this case.

				Jaroslav

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.