linux-kernel - Re: [PATCH] eeprom: ee1004: Unlock on error path in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19bb8ed0-e783-49aa-a4cd-6a0c3b89f0a8@web.de>
Date: Fri, 12 Jul 2024 17:42:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 kernel-janitors@...r.kernel.org, Armin Wolf <W_Armin@....de>
Cc: LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Günter Röck <linux@...ck-us.net>,
 Heiner Kallweit <hkallweit1@...il.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>
Subject: Re: [PATCH] eeprom: ee1004: Unlock on error path in probe()

> Call mutex_unlock() before returning an error in ee1004_probe()

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&ee1004_bus_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/mutex.h#L196


Would you like to refer to the function name “ee1004_probe” in the summary phrase?

Regards,
Markus