linux-kernel - Re: [PATCH] eeprom: ee1004: Unlock on error path in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024071235-exposure-overkill-356a@gregkh>
Date: Fri, 12 Jul 2024 18:14:43 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	kernel-janitors@...r.kernel.org, Armin Wolf <W_Armin@....de>,
	LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
	Günter Röck <linux@...ck-us.net>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>
Subject: Re: [PATCH] eeprom: ee1004: Unlock on error path in probe()

On Fri, Jul 12, 2024 at 05:42:12PM +0200, Markus Elfring wrote:
> > Call mutex_unlock() before returning an error in ee1004_probe()
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&ee1004_bus_lock);”?
> https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/mutex.h#L196
> 
> 
> Would you like to refer to the function name “ee1004_probe” in the summary phrase?

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot