linux-kernel - Re: [PATCH] ubi: Fix ubi_init() ubiblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c624cf1-b5a3-f89c-ac6a-0875fcabaf25@huawei.com>
Date: Sat, 13 Jul 2024 16:16:15 +0800
From: Zhihao Cheng <chengzhihao1@...wei.com>
To: Richard Weinberger <richard@....at>, <linux-mtd@...ts.infradead.org>
CC: <linux-kernel@...r.kernel.org>, Ben Hutchings <bwh@...nel.org>, kernel
 test robot <lkp@...el.com>
Subject: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch

在 2024/7/13 15:35, Richard Weinberger 写道:
> Since ubiblock_exit() is now called from an init function,
> the __exit section no longer makes sense.
> 
> Cc: Ben Hutchings <bwh@...nel.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>   drivers/mtd/ubi/block.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Looks like that you prefer a simpler fix. Feel fine to add

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
> 
> diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
> index bf7308e8ec2fe..60d0155be869f 100644
> --- a/drivers/mtd/ubi/block.c
> +++ b/drivers/mtd/ubi/block.c
> @@ -670,7 +670,7 @@ int __init ubiblock_init(void)
>   	return ret;
>   }
>   
> -void __exit ubiblock_exit(void)
> +void ubiblock_exit(void)
>   {
>   	ubi_unregister_volume_notifier(&ubiblock_notifier);
>   	ubiblock_remove_all();
>