linux-kernel - Re: [PATCH] ubi: Fix ubi_init() ubiblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422580650.65606.1720860390692.JavaMail.zimbra@nod.at>
Date: Sat, 13 Jul 2024 10:46:30 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: chengzhihao1 <chengzhihao1@...wei.com>
Cc: linux-mtd <linux-mtd@...ts.infradead.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	Ben Hutchings <bwh@...nel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch

----- Ursprüngliche Mail -----
> Von: "chengzhihao1" <chengzhihao1@...wei.com>
> An: "richard" <richard@....at>, "linux-mtd" <linux-mtd@...ts.infradead.org>
> CC: "linux-kernel" <linux-kernel@...r.kernel.org>, "Ben Hutchings" <bwh@...nel.org>, "kernel test robot" <lkp@...el.com>
> Gesendet: Samstag, 13. Juli 2024 10:16:15
> Betreff: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch

> 在 2024/7/13 15:35, Richard Weinberger 写道:
>> Since ubiblock_exit() is now called from an init function,
>> the __exit section no longer makes sense.
>> 
>> Cc: Ben Hutchings <bwh@...nel.org>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/
>> Signed-off-by: Richard Weinberger <richard@....at>
>> ---
>>   drivers/mtd/ubi/block.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Looks like that you prefer a simpler fix. Feel fine to add

Yes, and Ben sent the patch first. :)
 
> Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>

Thanks for the review!
And especially thanks for reviewing so many UBI/UBIFS patches,
I appreciate your help.

Thanks,
//richard