linux-kernel - Re: [PATCH] mm/hwpoison: reset hwpoison filter parameters in pfn_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240715133338.fb8b3b9a99f05b086fc54b82@linux-foundation.org>
Date: Mon, 15 Jul 2024 13:33:38 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Miaohe Lin <linmiaohe@...wei.com>
Cc: <nao.horiguchi@...il.com>, <linux-mm@...ck.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/hwpoison: reset hwpoison filter parameters in
 pfn_inject_exit()

On Mon, 15 Jul 2024 18:28:06 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:

> When hwpoison_inject module is removed, hwpoison_filter_* parameters
> should be reset. Otherwise these parameters will have non-default values
> at next insmod time.
> 
> ...
>
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -64,9 +64,20 @@ static int hwpoison_unpoison(void *data, u64 val)
>  DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
>  DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>  
> -static void __exit pfn_inject_exit(void)
> +static inline void reset_hwpoison_filter(void)
>  {
>  	hwpoison_filter_enable = 0;
> +	hwpoison_filter_dev_major = ~0U;
> +	hwpoison_filter_dev_minor = ~0U;
> +	hwpoison_filter_flags_mask = 0;
> +	hwpoison_filter_flags_value = 0;
> +#ifdef CONFIG_MEMCG
> +	hwpoison_filter_memcg = 0;
> +#endif
> +}
> +
> +static void __exit pfn_inject_exit(void)
> +{
>  	debugfs_remove_recursive(hwpoison_dir);
>  }

The new reset_hwpoison_filter() has no callers?