linux-kernel - Re: [PATCH] mm/hwpoison: reset hwpoison filter parameters in pfn_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29487e61-8785-0064-6208-5044b6419c9c@huawei.com>
Date: Tue, 16 Jul 2024 10:37:54 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: <nao.horiguchi@...il.com>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/hwpoison: reset hwpoison filter parameters in
 pfn_inject_exit()

On 2024/7/16 4:33, Andrew Morton wrote:
> On Mon, 15 Jul 2024 18:28:06 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:
> 
>> When hwpoison_inject module is removed, hwpoison_filter_* parameters
>> should be reset. Otherwise these parameters will have non-default values
>> at next insmod time.
>>
>> ...
>>
>> --- a/mm/hwpoison-inject.c
>> +++ b/mm/hwpoison-inject.c
>> @@ -64,9 +64,20 @@ static int hwpoison_unpoison(void *data, u64 val)
>>  DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
>>  DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>>  
>> -static void __exit pfn_inject_exit(void)
>> +static inline void reset_hwpoison_filter(void)
>>  {
>>  	hwpoison_filter_enable = 0;
>> +	hwpoison_filter_dev_major = ~0U;
>> +	hwpoison_filter_dev_minor = ~0U;
>> +	hwpoison_filter_flags_mask = 0;
>> +	hwpoison_filter_flags_value = 0;
>> +#ifdef CONFIG_MEMCG
>> +	hwpoison_filter_memcg = 0;
>> +#endif
>> +}
>> +
>> +static void __exit pfn_inject_exit(void)
>> +{
>>  	debugfs_remove_recursive(hwpoison_dir);
>>  }
> 
> The new reset_hwpoison_filter() has no callers?

I'm sorry but I can't figure out why that's missed. I remember I tested this patch
and queued it... Will send a new version and re-test it.
Thanks.
.