linux-kernel - Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26f70671-7b3b-48db-bdd9-f54f68f080a5@sirena.org.uk>
Date: Mon, 15 Jul 2024 13:48:21 +0100
From: Mark Brown <broonie@...nel.org>
To: Jaroslav Kysela <perex@...ex.cz>
Cc: Takashi Iwai <tiwai@...e.de>, Takashi Iwai <tiwai@...e.com>,
	Shuah Khan <shuah@...nel.org>, linux-sound@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test
 names

On Sat, Jul 13, 2024 at 09:35:36AM +0200, Jaroslav Kysela wrote:
> On 12. 07. 24 20:19, Mark Brown wrote:

> > Sure, but the genesis of this patch is that probe order isn't
> > sufficiently stable and we want to avoid names based on it...  using the
> > ID will be more likely to work out stable than just pure probe order but
> > it's still got the same issue.

> The probe order is almost stable for the drivers with the non-deferred
> probe. Also, administrators may set persistent ID for complex hardware

It's not very stable for modules being loaded, there's enough going on
and enough module loads happening simultaneously that it's very easy for
drivers to come up in different orders.  I'm seeing these issues quite
frequently in my test farm.

> configuration cases based on other keys like serial number or so
> (sysfs/udev).

For a lot of test scenarios that's just not really relevant - with a
pool of machines any per machine keys get hard to manage, and for
something like kernelci.org customising the rootfs for even classes of
boards never mind specific boards is going to be an unreasonable ask.

> For long name - the device path may change (USB moved to different port, PCI
> card moved to different slot), so the stability of this string is also
> questionable.

The concern here is repeated boots on the same system in an automated
context, if someone changes the hardware then it's reasonable that the
set of cards would change.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)