linux-kernel - Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <652d6fef-9e63-4c3c-b61b-8a47d6eadaf1@sirena.org.uk>
Date: Mon, 15 Jul 2024 14:18:44 +0100
From: Mark Brown <broonie@...nel.org>
To: Takashi Iwai <tiwai@...e.de>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Shuah Khan <shuah@...nel.org>, linux-sound@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test
 names

On Sat, Jul 13, 2024 at 08:46:43AM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > Sure, but the genesis of this patch is that probe order isn't
> > sufficiently stable and we want to avoid names based on it...  using the
> > ID will be more likely to work out stable than just pure probe order but
> > it's still got the same issue.

> Are you trying to solve the issue with two cards of the same driver,
> which are swapped sometimes at the probe time?  Or the mixture of
> different cards that are swapped?

The one I'm running into personally is due to the load order of the
sound card drivers themselves, but it seems good to try to address the
issue in general especially with ASoC where you're waiting for multiple
drivers for individual components in the card.  That means that even for
a single driver the ordering might not be stable.

> In the latter case, id should work well.  The id is primarily created
> from the (short)name string, and the suffix is added only when
> conflicting.

Yeah, it's more stable but there's still a potential issue.

> OTOH, if the former is the problem, using longname won't help,
> either, rather it can be confusing.  I noticed that the test output
> truncates the name string, hence both cards look identical in the
> actual output (except for the card listing at the beginning).

Interesting - I was mainly developing on a system with multiple HDA
cards and was getting fairly clearly unique names.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)