linux-kernel - Re: [PATCH] vfio-mdev: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3717c990-ac93-4a43-a33c-bce02a066dfd@quicinc.com>
Date: Mon, 15 Jul 2024 09:17:41 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Alex Williamson <alex.williamson@...hat.com>,
        Kirti Wankhede
	<kwankhede@...dia.com>
CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] vfio-mdev: add MODULE_DESCRIPTION() macros

On 7/12/2024 3:36 PM, Alex Williamson wrote:>>>>   MODULE_LICENSE("GPL v2");
>>>>   MODULE_INFO(supported, "Test driver that simulate serial port over PCI");
>>>> +MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
> 
> Seems the preceding MODULE_INFO needs to be removed here.  At best the
> added MODULE_DESCRIPTION is redundant, but "supported" is not a
> standard tag, so it's not clear what the purpose of that tag was meant
> to be anyway.  Thanks,
> 
> Alex

My preference would be to just add the missing MODULE_DESCRIPTION() with this
patch since that fixes the existing warning. Removing an existing macro
invocation is out of scope for what I'm trying to accomplish.

Out of almost 300 patches treewide that add missing MODULE_DESCRIPTION()
macros, this is one of 13 that is still pending for the 6.11 merge window.

/jeff