linux-kernel - Re: [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lj3rlnhffccwunowrjvk7i6pq6gcpg6rzdmvspwhjdiqfmfvob@a45kjy2du77z>
Date: Mon, 15 Jul 2024 12:17:44 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Wei Yang <richard.weiyang@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH 1/2] radix tree test suite: include kconfig.h with
 incomplete path

* Wei Yang <richard.weiyang@...il.com> [240712 03:42]:
> The include path indicates it is the kconfig.h in tools/include/linux.
> 
> Let's use the same format as others for better reading.

nack

This change stops using tools/testing/radix-tree/generated/autoconf.h
which is included from kconfig.h.

If you add an #error to that generated/autoconf.h header, then you will
see it will build with your change, but fails with the existing code.

So this is not equivalent.

> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
> CC: "Liam R. Howlett" <Liam.Howlett@...cle.com>
> CC: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>  tools/testing/radix-tree/linux/kernel.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/radix-tree/linux/kernel.h b/tools/testing/radix-tree/linux/kernel.h
> index c0a2bb785b92..fab6f47a9472 100644
> --- a/tools/testing/radix-tree/linux/kernel.h
> +++ b/tools/testing/radix-tree/linux/kernel.h
> @@ -11,7 +11,7 @@
>  #include <linux/err.h>
>  #include <linux/bitops.h>
>  #include <linux/log2.h>
> -#include "../../../include/linux/kconfig.h"
> +#include <linux/kconfig.h>
>  
>  #define printk printf
>  #define pr_err printk
> -- 
> 2.34.1
>