linux-kernel - Re: [PATCH v2] arm64: remove redundant 'if HAVE_ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34b1f29a-675b-4b89-a398-7ed3b732d1ac@arm.com>
Date: Tue, 16 Jul 2024 09:49:12 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Masahiro Yamada <masahiroy@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 linux-arm-kernel@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
 Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2] arm64: remove redundant 'if HAVE_ARCH_KASAN' in
 Kconfig



On 7/16/24 00:58, Masahiro Yamada wrote:
> Since commit 0383808e4d99 ("arm64: kasan: Reduce minimum shadow
> alignment and enable 5 level paging"), HAVE_ARCH_KASAN is always 'y'.
> 
> The condition 'if HAVE_ARCH_KASAN' is always met.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
> Acked-by: Mark Rutland <mark.rutland@....com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>

> ---
> 
> Changes in v2:
>  - update description
>  - add reviewed-by and acked-by
> 
>  arch/arm64/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index c87d16b12e9b..d37cbfc3031e 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -167,9 +167,9 @@ config ARM64
>  	select HAVE_ARCH_JUMP_LABEL
>  	select HAVE_ARCH_JUMP_LABEL_RELATIVE
>  	select HAVE_ARCH_KASAN
> -	select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN
> -	select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN
> -	select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE)
> +	select HAVE_ARCH_KASAN_VMALLOC
> +	select HAVE_ARCH_KASAN_SW_TAGS
> +	select HAVE_ARCH_KASAN_HW_TAGS if ARM64_MTE
>  	# Some instrumentation may be unsound, hence EXPERT
>  	select HAVE_ARCH_KCSAN if EXPERT
>  	select HAVE_ARCH_KFENCE