linux-kernel - Re: [PATCH] kselftest: missing arg in ptrace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7383c8c-83f3-45da-a8c4-2cfcfa497936@arm.com>
Date: Tue, 16 Jul 2024 09:49:12 +0530
From: Dev Jain <dev.jain@....com>
To: Remington Brasga <rbrasga@....edu>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Shuah Khan <shuah@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linuxfoundation.org, Anshuman.Khandual@....com,
 Mark Brown <broonie@...nel.org>, Ryan Roberts <ryan.roberts@....com>
Subject: Re: [PATCH] kselftest: missing arg in ptrace.c


On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@....edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
>
>   tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
>   		/* Zero is not currently architecturally valid */
>   		ksft_test_result(arch, "%s_arch_set\n", type_name);
>   	} else {
> -		ksft_test_result_skip("%s_arch_set\n");
> +		ksft_test_result_skip("%s_arch_set\n", type_name);
>   	}
>   }

Okay, I almost forgot that I had a patch fixing this as part of another series:
https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
If that is OK, Will, can you please pull that? Or should I send that as a
separate patch?