linux-kernel - Re: [PATCH 2/6] input: qt1050: use device_for_each_child_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZpX10HRCFMhBbeoU@google.com>
Date: Mon, 15 Jul 2024 21:23:44 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] input: qt1050: use
 device_for_each_child_node_scoped()

On Tue, Jul 16, 2024 at 06:17:35AM +0200, Javier Carrasco wrote:
> On 16/07/2024 03:03, Dmitry Torokhov wrote:
> > Hi Javier,
> > 
> > On Fri, Apr 12, 2024 at 10:57:31PM +0200, Javier Carrasco wrote:
> >> Switch to the _scoped() version introduced in commit 365130fd47af
> >> ("device property: Introduce device_for_each_child_node_scoped()")
> >> to remove the need for manual calling of fwnode_handle_put() in the
> >> paths where the code exits the loop early.
> >>
> >> In this case the err label was no longer necessary and EINVAL is
> >> returned directly.
> >>
> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> >> ---
> >>  drivers/input/keyboard/qt1050.c | 12 ++++--------
> >>  1 file changed, 4 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
> >> index b51dfcd76038..6ac2b9dbdb85 100644
> >> --- a/drivers/input/keyboard/qt1050.c
> >> +++ b/drivers/input/keyboard/qt1050.c
> >> @@ -355,21 +355,21 @@ static int qt1050_parse_fw(struct qt1050_priv *ts)
> >>  		if (fwnode_property_read_u32(child, "linux,code",
> >>  					     &button.keycode)) {
> >>  			dev_err(dev, "Button without keycode\n");
> >> -			goto err;
> >> +			return -EINVAL;
> > 
> > It looks like the chunk actually switching to
> > device_for_each_child_node_scoped() is missing from the patch. I added
> > it and applied, thank you.
> > 
> > Thanks.
> > 
> 
> 
> Thank your for adding the missing bit. Did you remove the child variable
> at the beginning of the function as well? It will be unused otherwise
> (child is defined in the macro itself).

Yep, I did.

Thanks.

-- 
Dmitry