linux-kernel - Re: [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04be66d2-de35-4190-ba9d-011b2b639f94@linaro.org>
Date: Tue, 16 Jul 2024 08:31:08 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Ceclan, Dumitru" <mitrutzceclan@...il.com>, dumitru.ceclan@...log.com
Cc: Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, David Lechner <dlechner@...libre.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 9/9] iio: adc: ad7173: Add support for AD411x devices

On 15/07/2024 19:17, Ceclan, Dumitru wrote:
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
>> Some warnings can be ignored, especially from --strict run, but the code
>> here looks like it needs a fix. Feel free to get in touch if the warning
>> is not clear.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I do not get any warnings, only checks
> 
> If you meant the checks:
> - for the alignment check, i would only argue for struct_group(config_props that looks good
> - for unnecessary parentheses the compiler warning appears without the parentheses:
>       warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]

Hm, in that case it looks like you documented some entirely different
bindings?

Best regards,
Krzysztof