linux-kernel - Re: [PATCH v3] thermal: core: Call monitor_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jkA72=avuthGkrS5iu_UGEQeaEp7LjedXCpzamcnRKsA@mail.gmail.com>
Date: Tue, 16 Jul 2024 12:05:28 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Stefan Lippers-Hollmann <s.l-h@....de>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	Eric Biggers <ebiggers@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, 
	Linux PM <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	Lukasz Luba <lukasz.luba@....com>, 
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Zhang Rui <rui.zhang@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v3] thermal: core: Call monitor_thermal_zone() if zone
 temperature is invalid

On Tue, Jul 16, 2024 at 1:48 AM Stefan Lippers-Hollmann <s.l-h@....de> wrote:
>
> Hi
>
> On 2024-07-15, Rafael J. Wysocki wrote:
> > On Mon, Jul 15, 2024 at 2:54 PM Stefan Lippers-Hollmann <s.l-h@....de> wrote:
> > > On 2024-07-15, Rafael J. Wysocki wrote:
> > > > On Mon, Jul 15, 2024 at 11:09 AM Daniel Lezcano
> > > > <daniel.lezcano@...aro.org> wrote:
> > > > > On 15/07/2024 06:45, Eric Biggers wrote:
> > > > > > On Thu, Jul 04, 2024 at 01:46:26PM +0200, Rafael J. Wysocki wrote:
> > > > > >> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> [...]
> > > Silencing the warnings is already a big improvement - and that patch
> > > works to this extent for me with an ax200, thanks.
> >
> > So attached is a patch that should avoid enabling the thermal zone
> > when it is not ready for use in the first place, so it should address
> > both the message and the useless polling.
> >
> > I would appreciate giving it a go (please note that it hasn't received
> > much testing so far, though).
>
> Sadly this patch doesn't seem to help:

This is likely because it is missing checks for firmware image type.
I've added them to the attached new version.  Please try it.

I've also added two pr_info() messages to get a better idea of what's
going on, so please grep dmesg for "Thermal zone not ready" and
"Enabling thermal zone".

In the meantime, I'll prepare thermal core changes that should
mitigate the problem independently.

View attachment "iwlwifi-mvm-zone-enabling-v2.patch" of type "text/x-patch" (6672 bytes)