linux-kernel - Re: [PATCH] perf annotate: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fW8pVzHD+AN73Y1WLBSqf9LLHtnwBkuuZ2OLK9sCmv1ww@mail.gmail.com>
Date: Tue, 16 Jul 2024 06:33:15 -0700
From: Ian Rogers <irogers@...gle.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org, 
	namhyung@...nel.org, mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
	jolsa@...nel.org, adrian.hunter@...el.com, kan.liang@...ux.intel.com, 
	nabijaczleweli@...ijaczleweli.xyz, penberg@...nel.org, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf annotate: Convert comma to semicolon

On Tue, Jul 16, 2024 at 12:35 AM Chen Ni <nichen@...as.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: aca7a94d6a59 ("perf tools: Move UI bits to tools/perf/ui directory")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/ui/browsers/annotate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index ea986430241e..fe991a81256b 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -985,7 +985,7 @@ int symbol__tui_annotate(struct map_symbol *ms, struct evsel *evsel,
>
>         browser.b.width = notes->src->widths.max_line_len;
>         browser.b.nr_entries = notes->src->nr_entries;
> -       browser.b.entries = &notes->src->source,
> +       browser.b.entries = &notes->src->source;
>         browser.b.width += 18; /* Percentage */
>
>         if (annotate_opts.hide_src_code)
> --
> 2.25.1
>