lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZqOu5NNK39IRBBLz@x1>
Date: Fri, 26 Jul 2024 11:12:52 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Chen Ni <nichen@...as.ac.cn>, peterz@...radead.org, mingo@...hat.com,
	namhyung@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	adrian.hunter@...el.com, kan.liang@...ux.intel.com,
	nabijaczleweli@...ijaczleweli.xyz, penberg@...nel.org,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf annotate: Convert comma to semicolon

On Tue, Jul 16, 2024 at 06:33:15AM -0700, Ian Rogers wrote:
> On Tue, Jul 16, 2024 at 12:35 AM Chen Ni <nichen@...as.ac.cn> wrote:
> >
> > Replace a comma between expression statements by a semicolon.
> >
> > Fixes: aca7a94d6a59 ("perf tools: Move UI bits to tools/perf/ui directory")

I'm removing this fixes tag to avoid churn on the stable trees, the
referred cset just moves things around, so its not where the harmless
comma was introduced.

Thanks, applied.

- Arnaldo

> > Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>
> 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/ui/browsers/annotate.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> > index ea986430241e..fe991a81256b 100644
> > --- a/tools/perf/ui/browsers/annotate.c
> > +++ b/tools/perf/ui/browsers/annotate.c
> > @@ -985,7 +985,7 @@ int symbol__tui_annotate(struct map_symbol *ms, struct evsel *evsel,
> >
> >         browser.b.width = notes->src->widths.max_line_len;
> >         browser.b.nr_entries = notes->src->nr_entries;
> > -       browser.b.entries = &notes->src->source,
> > +       browser.b.entries = &notes->src->source;
> >         browser.b.width += 18; /* Percentage */
> >
> >         if (annotate_opts.hide_src_code)
> > --
> > 2.25.1
> >

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ