linux-kernel - Re: [PATCH] latencytop: Use seq_putc() in lstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240716154520.vtlqv4jxlihy2h7r@joelS2.panther.com>
Date: Tue, 16 Jul 2024 17:45:20 +0200
From: Joel Granados <j.granados@...sung.com>
To: Markus Elfring <Markus.Elfring@....de>
CC: <kernel-janitors@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	<arjan@...ux.intel.com>
Subject: Re: [PATCH] latencytop: Use seq_putc() in lstats_show()

On Sun, Jul 14, 2024 at 12:00:23PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 14 Jul 2024 11:52:13 +0200

Not sure why this got forwarded to me. ccing arjan@...ux.intel.com
as he seems to be the author of the file.
> 
> A single line break should be put into a sequence.
> Thus use the corresponding function “seq_putc”.
> 
> This issue was transformed by using the Coccinelle software.

A couple of comments while I'm here:
* The "why" is not clear; please clarify why a single line break should
  be put into a sequence.
* I don't think that a one liner merits the "coccinelle" comment.
  However, if you *really* think it should be there, please add more
  information, like the conccinell script.

Best

-- 

Joel Granados