linux-kernel - Re: latencytop: Use seq_putc() in lstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1b7f067-efa9-4550-8351-8923a71826fa@web.de>
Date: Tue, 16 Jul 2024 19:06:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Joel Granados <j.granados@...sung.com>, kernel-janitors@...r.kernel.org,
 cocci@...ia.fr
Cc: LKML <linux-kernel@...r.kernel.org>,
 Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: latencytop: Use seq_putc() in lstats_show()

> Not sure why this got forwarded to me.

The script “get_maintainer.pl” pointed your recent contribution out.


>> A single line break should be put into a sequence.
>> Thus use the corresponding function “seq_putc”.
>>
>> This issue was transformed by using the Coccinelle software.
>
> A couple of comments while I'm here:
> * The "why" is not clear; please clarify why a single line break should
>   be put into a sequence.

This is a desired data processing effect here.
https://elixir.bootlin.com/linux/v6.10/source/kernel/latencytop.c#L263


> * I don't think that a one liner merits the "coccinelle" comment.
>   However, if you *really* think it should be there, please add more
>   information, like the conccinell script.

I would appreciate if another SmPL script can eventually be integrated
for the coccicheck tool.

Regards,
Markus