linux-kernel - Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5pgipwi7ckrjxec7yzqxnvnoggjsnvhb2mtcq5hcwanhp6t5tt@z4s6ouppd2vz>
Date: Tue, 16 Jul 2024 20:08:37 +0300
From: Florian Klink <flokli@...kli.de>
To: Stefan Wahren <wahrenst@....net>
Cc: Florian Fainelli <f.fainelli@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin

Hey,

fine with the subject change too :-)

@Florian: Let me know if you want me to roll all in a v2 or are happy to
apply that subject change too.

Cheers,
flokli

On Tue, Jul 16, 2024 at 07:30:32AM GMT, Stefan Wahren wrote:
>Hi,
>
>Am 16.07.24 um 01:19 schrieb Florian Fainelli:
>>+Stefan,
>>
>>On 7/15/24 16:03, Florian Klink wrote:
>>>HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>>>
>>>This fixes HDMI hotplug/output detection.
>>>
>>>See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>>>
>>>Signed-off-by: Florian Klink <flokli@...kli.de>
>>
>>Assuming Stefan is OK wit the change, I will apply this along with a:
>>
>>Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and
>>IO board")
>thanks for fixing and i'm fine with this change. The GPIO line names are
>already correct.
>
>Maybe the subject should be more specific:
>
>ARM: dts: bcm2837-rpi-cm3-io3: Fix HDMI hpd-gpio pin
>
>Except of this:
>
>Reviewed-by: Stefan Wahren <wahrenst@....net>
>
>Regards
>>
>>>---
>>>  arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>index 72d26d130efa..85f54fa595aa 100644
>>>--- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>+++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>@@ -77,7 +77,7 @@ &gpio {
>>>  };
>>>    &hdmi {
>>>-    hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
>>>+    hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
>>>      power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
>>>      status = "okay";
>>>  };
>>
>

-- 
Florian Klink