linux-kernel - Re: [PATCH] PCI/pwrctl: reduce the amount of Kconfig noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240716163312.GN3446@thinkpad>
Date: Tue, 16 Jul 2024 22:03:12 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] PCI/pwrctl: reduce the amount of Kconfig noise

On Tue, Jul 16, 2024 at 06:29:04PM +0200, Bartosz Golaszewski wrote:
> On Tue, Jul 16, 2024 at 5:59 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@...aro.org> wrote:
> >
> > On Tue, Jul 16, 2024 at 05:23:18PM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >
> > > Kconfig will ask the user twice about power sequencing: once for the QCom
> > > WCN power sequencing driver and then again for the PCI power control
> > > driver using it.
> > >
> > > Let's remove the public menuconfig entry for PCI pwrctl and instead
> > > default the relevant symbol to 'm' only for the architectures that
> > > actually need it.
> > >
> >
> > Why can't you put it in defconfig instead?
> >
> 
> Only Qualcomm uses it right now. I don't think it's worth building it
> for everyone just yet. Let's cross that bridge when we have more
> platforms selecting it?
> 

This is the same case for rest of the Qcom specific drivers as well, but we
enable it in ARM/ARM64 defconfig. So I think this driver should also follow the
same.

- Mani

-- 
மணிவண்ணன் சதாசிவம்