[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=Mdr3QaP1-tLwH9Oyjw1+8mfCsNj18u3YGwpHTmhBtB6OA@mail.gmail.com>
Date: Tue, 16 Jul 2024 19:38:46 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] PCI/pwrctl: reduce the amount of Kconfig noise
On Tue, Jul 16, 2024 at 6:33 PM Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:
>
> On Tue, Jul 16, 2024 at 06:29:04PM +0200, Bartosz Golaszewski wrote:
> > On Tue, Jul 16, 2024 at 5:59 PM Manivannan Sadhasivam
> > <manivannan.sadhasivam@...aro.org> wrote:
> > >
> > > On Tue, Jul 16, 2024 at 05:23:18PM +0200, Bartosz Golaszewski wrote:
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > > >
> > > > Kconfig will ask the user twice about power sequencing: once for the QCom
> > > > WCN power sequencing driver and then again for the PCI power control
> > > > driver using it.
> > > >
> > > > Let's remove the public menuconfig entry for PCI pwrctl and instead
> > > > default the relevant symbol to 'm' only for the architectures that
> > > > actually need it.
> > > >
> > >
> > > Why can't you put it in defconfig instead?
> > >
> >
> > Only Qualcomm uses it right now. I don't think it's worth building it
> > for everyone just yet. Let's cross that bridge when we have more
> > platforms selecting it?
> >
>
> This is the same case for rest of the Qcom specific drivers as well, but we
> enable it in ARM/ARM64 defconfig. So I think this driver should also follow the
> same.
>
Ok, so let's do it in the next cycle.
Bart
Powered by blists - more mailing lists