linux-kernel - Re: [PATCH] dmaengine: pl330: Handle the return value of pl330

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrcGYocPKy-WB3EdB+Jx0=BztzXz1r=5y3JNTeXF84-7g@mail.gmail.com>
Date: Wed, 17 Jul 2024 13:30:29 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: vkoul@...nel.org, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: Handle the return value of pl330_resume

On Wed, 17 Jul 2024 at 09:29, Chen Ni <nichen@...as.ac.cn> wrote:
>
> As pm_runtime_force_resume() can return error numbers, it should be
> better to check the return value and deal with the exception.
>
> Fixes: a39cddc9e377 ("dmaengine: pl330: Drop boilerplate code for suspend/resume")
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  drivers/dma/pl330.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 60c4de8dac1d..624ab4eee156 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2993,9 +2993,7 @@ static int __maybe_unused pl330_resume(struct device *dev)
>         if (ret)
>                 return ret;
>
> -       pm_runtime_force_resume(dev);
> -
> -       return ret;
> +       return pm_runtime_force_resume(dev);
>  }
>
>  static const struct dev_pm_ops pl330_pm = {
> --
> 2.25.1
>
>