linux-kernel - Re: [PATCH] dmaengine: pl330: Handle the return value of pl330

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a41053b4-b42d-4aca-a8dd-c9f4c901e5dc@web.de>
Date: Wed, 17 Jul 2024 13:45:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Chen Ni <nichen@...as.ac.cn>, dmaengine@...r.kernel.org,
 Ulf Hansson <ulf.hansson@...aro.org>, Vinod Koul <vkoul@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: pl330: Handle the return value of pl330_resume

> As pm_runtime_force_resume() can return error numbers, it should be
> better to check the return value and deal with the exception.

Please improve such a change description with an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94

How do you think about to use a summary phrase like “Return value from
a pm_runtime_force_resume() call in pl330_resume()”?

Regards,
Markus