linux-kernel - Re: [PATCH v2] sysctl: treewide: constify the ctl_table argument of proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdf0831f-f9af-4aa7-a3a0-970efeec1def@t-8ch.de>
Date: Wed, 17 Jul 2024 17:26:44 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Joel Granados <j.granados@...sung.com>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <kees@...nel.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sysctl: treewide: constify the ctl_table argument of
 proc_handlers

On 2024-07-16 17:27:05+0000, Joel Granados wrote:
> On Mon, Jul 15, 2024 at 10:58:10PM +0200, Thomas Weißschuh wrote:
> > On 2024-07-15 22:23:19+0000, Joel Granados wrote:
> ...
> > > The merge window is now open. I want to send this patch on the Wednesday
> > > of next week (jul 24).

<snip>

> > > 2. Does it still apply cleanly against the latest master branch?
> > 
> > Not against mainline master, but against next-20240715.
> > To apply cleanly (and compile) on mainline master it still requires the
> > net/ and sysctl trees to be merged.
> > Otherwise some modified functions are missing, leading to (trivial) merge
> > conflicts or the preparation commits are missing, leading to compilation
> > errors.
> 
> Understood. I have just sent Linus the changes for sysctl-next, so those
> should land in master soon (baring any issues with the pull request).
> 
> These [1] and [2] are the two series in net-dev that are the deps for
> the constification treewide patch. Once these two go into mainline, then
> we are good to go. Right?

Right, but...

It turns out the preparation patch for mm/hugetlb.c [0] is also still
missing. I missed it in all the errors triggered in net/.
But as far as I can see this patch will be part of Andrew's PR for mm.

Other than that it looks good.

<snip>

[0] https://lore.kernel.org/lkml/20240518-sysctl-const-handler-hugetlb-v1-1-47e34e2871b2@weissschuh.net/

> [1] net: constify ctl_table arguments of utility functions
>     https://patchwork.kernel.org/project/netdevbpf/list/?series=856252&state=%2A&archive=both
> [2] bpf: constify member bpf_sysctl_kern::table
>     https://patchwork.kernel.org/project/netdevbpf/list/?series=854191&state=*