linux-kernel - Re: [PATCH v9 37/39] kselftest/arm64: Add GCS signal tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5iexpyq.fsf@linaro.org>
Date: Thu, 18 Jul 2024 20:03:41 -0300
From: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
To: Mark Brown <broonie@...nel.org>
Cc: Catalin Marinas <catalin.marinas@....com>,  Will Deacon
 <will@...nel.org>,  Jonathan Corbet <corbet@....net>,  Andrew Morton
 <akpm@...ux-foundation.org>,  Marc Zyngier <maz@...nel.org>,  Oliver Upton
 <oliver.upton@...ux.dev>,  James Morse <james.morse@....com>,  Suzuki K
 Poulose <suzuki.poulose@....com>,  Arnd Bergmann <arnd@...db.de>,  Oleg
 Nesterov <oleg@...hat.com>,  Eric Biederman <ebiederm@...ssion.com>,
  Shuah Khan <shuah@...nel.org>,  "Rick P. Edgecombe"
 <rick.p.edgecombe@...el.com>,  Deepak Gupta <debug@...osinc.com>,  Ard
 Biesheuvel <ardb@...nel.org>,  Szabolcs Nagy <Szabolcs.Nagy@....com>,
  Kees Cook <kees@...nel.org>,  "H.J. Lu" <hjl.tools@...il.com>,  Paul
 Walmsley <paul.walmsley@...ive.com>,  Palmer Dabbelt <palmer@...belt.com>,
  Albert Ou <aou@...s.berkeley.edu>,  Florian Weimer <fweimer@...hat.com>,
  Christian Brauner <brauner@...nel.org>,  Ross Burton
 <ross.burton@....com>,  linux-arm-kernel@...ts.infradead.org,
  linux-doc@...r.kernel.org,  kvmarm@...ts.linux.dev,
  linux-fsdevel@...r.kernel.org,  linux-arch@...r.kernel.org,
  linux-mm@...ck.org,  linux-kselftest@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v9 37/39] kselftest/arm64: Add GCS signal tests

Mark Brown <broonie@...nel.org> writes:

> Do some testing of the signal handling for GCS, checking that a GCS
> frame has the expected information in it and that the expected signals
> are delivered with invalid operations.
>
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  tools/testing/selftests/arm64/signal/.gitignore    |  1 +
>  .../selftests/arm64/signal/test_signals_utils.h    | 10 +++
>  .../arm64/signal/testcases/gcs_exception_fault.c   | 62 +++++++++++++++
>  .../selftests/arm64/signal/testcases/gcs_frame.c   | 88 ++++++++++++++++++++++
>  .../arm64/signal/testcases/gcs_write_fault.c       | 67 ++++++++++++++++
>  5 files changed, 228 insertions(+)

The gcs_write_fault test fails for me, even without THP:

$ sudo ./run_kselftest.sh -t arm64:gcs_write_fault
TAP version 13
1..1
# timeout set to 45
# selftests: arm64: gcs_write_fault
# # GCS write fault :: Normal writes to a GCS segfault
# Registered handlers for all signals.
# Detected MINSTKSIGSZ:4720
# Required Features: [ GCS ] supported
# Incompatible Features: [] absent
# Testcase initialized.
# Read value 0x0
# SIG_OK -- SP:0xFFFFCF1292D0  si_addr@:0xffffba645000  si_code:10  token@:(nil)  offset:-281473808879616
# si_code != SEGV_ACCERR...test is probably broken!
# -- RX UNEXPECTED SIGNAL: 6 code -6 address 0xf76
# ==>> completed. FAIL(0)
not ok 1 selftests: arm64: gcs_write_fault # exit=1

It also generates an "INVALID GCS" line in dmesg.

-- 
Thiago