linux-kernel - Re: [PATCH v9 38/39] kselftest/arm64: Add a GCS stress test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xt2xojp.fsf@linaro.org>
Date: Thu, 18 Jul 2024 20:34:18 -0300
From: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
To: Mark Brown <broonie@...nel.org>
Cc: Catalin Marinas <catalin.marinas@....com>,  Will Deacon
 <will@...nel.org>,  Jonathan Corbet <corbet@....net>,  Andrew Morton
 <akpm@...ux-foundation.org>,  Marc Zyngier <maz@...nel.org>,  Oliver Upton
 <oliver.upton@...ux.dev>,  James Morse <james.morse@....com>,  Suzuki K
 Poulose <suzuki.poulose@....com>,  Arnd Bergmann <arnd@...db.de>,  Oleg
 Nesterov <oleg@...hat.com>,  Eric Biederman <ebiederm@...ssion.com>,
  Shuah Khan <shuah@...nel.org>,  "Rick P. Edgecombe"
 <rick.p.edgecombe@...el.com>,  Deepak Gupta <debug@...osinc.com>,  Ard
 Biesheuvel <ardb@...nel.org>,  Szabolcs Nagy <Szabolcs.Nagy@....com>,
  Kees Cook <kees@...nel.org>,  "H.J. Lu" <hjl.tools@...il.com>,  Paul
 Walmsley <paul.walmsley@...ive.com>,  Palmer Dabbelt <palmer@...belt.com>,
  Albert Ou <aou@...s.berkeley.edu>,  Florian Weimer <fweimer@...hat.com>,
  Christian Brauner <brauner@...nel.org>,  Ross Burton
 <ross.burton@....com>,  linux-arm-kernel@...ts.infradead.org,
  linux-doc@...r.kernel.org,  kvmarm@...ts.linux.dev,
  linux-fsdevel@...r.kernel.org,  linux-arch@...r.kernel.org,
  linux-mm@...ck.org,  linux-kselftest@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v9 38/39] kselftest/arm64: Add a GCS stress test

Mark Brown <broonie@...nel.org> writes:

> Add a stress test which runs one more process than we have CPUs spinning
> through a very recursive function with frequent syscalls immediately prior
> to return and signals being injected every 100ms. The goal is to flag up
> any scheduling related issues, for example failure to ensure that barriers
> are inserted when moving a GCS using task to another CPU. The test runs for
> a configurable amount of time, defaulting to 10 seconds.
>
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  tools/testing/selftests/arm64/gcs/.gitignore       |   2 +
>  tools/testing/selftests/arm64/gcs/Makefile         |   6 +-
>  tools/testing/selftests/arm64/gcs/asm-offsets.h    |   0
>  .../selftests/arm64/gcs/gcs-stress-thread.S        | 311 ++++++++++++
>  tools/testing/selftests/arm64/gcs/gcs-stress.c     | 532 +++++++++++++++++++++
>  5 files changed, 850 insertions(+), 1 deletion(-)

This test fails for me, even without THP:

$ sudo ./run_kselftest.sh -t arm64:gcs-stress
TAP version 13
1..1
# timeout set to 45
# selftests: arm64: gcs-stress
# TAP version 13
# 1..9
# # 8 CPUs, 9 GCS threads
# # Will run for 10s
# # Started Thread-4030
# # Started Thread-4031
# # Started Thread-4032
# # Started Thread-4033
# # Started Thread-4034
# # Started Thread-4035
# # Started Thread-4036
# # Started Thread-4037
# # Started Thread-4038
# # Waiting for 9 children
# # Waiting for 9 children
# # Thread-4030: Failed to enable GCS
# # Thread-4031: Failed to enable GCS
# # Thread-4032: Failed to enable GCS
# # Thread-4033: Failed to enable GCS
# # Thread-4034: Failed to enable GCS
# # Thread-4035: Failed to enable GCS
# # Thread-4036: Failed to enable GCS
# # Thread-4038: Failed to enable GCS
# # Thread-4037: Failed to enable GCS
# # Sending signals, timeout remaining: 10000ms
# # Sending signals, timeout remaining: 9900ms
    ⋮
# # Sending signals, timeout remaining: 200ms
# # Sending signals, timeout remaining: 100ms
# # Finishing up...
# # Thread-4030 exited with error code 255
# not ok 1 Thread-4030
# # Thread-4031 exited with error code 255
# not ok 2 Thread-4031
# # Thread-4032 exited with error code 255
# not ok 3 Thread-4032
# # Thread-4033 exited with error code 255
# not ok 4 Thread-4033
# # Thread-4034 exited with error code 255
# not ok 5 Thread-4034
# # Thread-4035 exited with error code 255
# not ok 6 Thread-4035
# # Thread-4036 exited with error code 255
# not ok 7 Thread-4036
# # Thread-4037 exited with error code 255
# not ok 8 Thread-4037
# # Thread-4038 exited with error code 255
# not ok 9 Thread-4038
# # Totals: pass:0 fail:9 xfail:0 xpass:0 skip:0 error:0
ok 1 selftests: arm64: gcs-stress

-- 
Thiago