linux-kernel - Re: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove manual counting and increase maintainability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7677dc6a-3162-4ca8-ab73-f5903ad820c9@collabora.com>
Date: Fri, 19 Jul 2024 12:28:36 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>, kernel@...labora.com,
 "Chang S . Bae" <chang.seok.bae@...el.com>,
 Binbin Wu <binbin.wu@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>,
 "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove
 manual counting and increase maintainability

On 7/18/24 8:48 PM, Shuah Khan wrote:
> On 7/18/24 05:32, Muhammad Usama Anjum wrote:
>> Removes manual counting of pass and fail tests. This increases readability
>> of tests, but also improves maintainability of the tests. Print logs in
>> standard format (without [RUN], [OK] tags)
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>> ---
>> Changes since v1:
>> - correct description of the patch
>>
>> Changes since v2:
>> - Update description of the patch and add before/after output
>>
>> Before:
>>    # selftests: x86: check_initial_reg_state_32
>>    # [OK]    All GPRs except SP are 0
>>    # [OK]    FLAGS is 0x202
>>    ok 5 selftests: x86: check_initial_reg_state_32
>>
>> After:
>>    # selftests: x86: check_initial_reg_state_32
>>    # TAP version 13
>>    # 1..2
>>    # ok 1 All GPRs except SP are 0
>>    # ok 2 FLAGS is 0x202
>>    # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0
>>    ok 5 selftests: x86: check_initial_reg_state_32
> 
> What's the output you see if you were run this as:
> 
> make ksefltest TARGETS=x86
> 
> How is this different from the output from the above command?
The above before and after output has been taken by executing this above
command. I've copy/pasted the snippets for this patch only.

> 
> Please provide the same information for your other patches in this
> series
All other patches have this information already.

> 
> thanks,
> -- Shuah
> 

-- 
BR,
Muhammad Usama Anjum