linux-kernel - Re: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove manual counting and increase maintainability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac945077-928b-42f1-9f38-9d26c8672711@linuxfoundation.org>
Date: Fri, 19 Jul 2024 10:52:28 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: kernel@...labora.com, "Chang S . Bae" <chang.seok.bae@...el.com>,
 Binbin Wu <binbin.wu@...ux.intel.com>, Ingo Molnar <mingo@...nel.org>,
 "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 1/4] selftests: x86: check_initial_reg_state: remove
 manual counting and increase maintainability

On 7/19/24 01:28, Muhammad Usama Anjum wrote:
> On 7/18/24 8:48 PM, Shuah Khan wrote:
>> On 7/18/24 05:32, Muhammad Usama Anjum wrote:
>>> Removes manual counting of pass and fail tests. This increases readability
>>> of tests, but also improves maintainability of the tests. Print logs in
>>> standard format (without [RUN], [OK] tags)
>>>
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
>>> ---
>>> Changes since v1:
>>> - correct description of the patch
>>>
>>> Changes since v2:
>>> - Update description of the patch and add before/after output
>>>
>>> Before:
>>>     # selftests: x86: check_initial_reg_state_32
>>>     # [OK]    All GPRs except SP are 0
>>>     # [OK]    FLAGS is 0x202
>>>     ok 5 selftests: x86: check_initial_reg_state_32
>>>
>>> After:
>>>     # selftests: x86: check_initial_reg_state_32
>>>     # TAP version 13
>>>     # 1..2
>>>     # ok 1 All GPRs except SP are 0
>>>     # ok 2 FLAGS is 0x202
>>>     # # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0
>>>     ok 5 selftests: x86: check_initial_reg_state_32
>>
>> What's the output you see if you were run this as:
>>
>> make ksefltest TARGETS=x86
>>

That is what is confusing to me. As mentioned in response to your
vDSO patch, this change to add ksft_header to individual tests.

When you run the test from the wrapper
if you want the header printed for q

>> How is this different from the output from the above command?
> The above before and after output has been taken by executing this above
> command. I've copy/pasted the snippets for this patch only.
> 

Yes. That is the problem. Youa re giving me snippets as opposed to
the header. When I run it I see TAP header at the top of the test
suite. The idea is that the TAP header should not be printed for
each test in the test suite.

It is printed once for test suite. What is the point in printing TAP
header for each of the tests in test suite if there are 100 tests
like in the case of break_points test.

Even if it is desired that each individual should have TAP header
(There has to be a good reason why - not because we want to see it),
this change should be added to

tools/testing/selftests/kselftest/runner.sh
This makes it uniform and maintainable.

Sorry. I am not going accept patches that add ksft header to individual
tests and test cases.

thanks,
-- Shuah